Wrong Exif Id in io-jpeg.c?



Hi,
 Per the Exif specification, and the comments within io-jpeg.c, the 6 byte Exif Marker (APP1 marker) should be  0x457869660000, or "Exif\0\0".

But, in  io-jpeg, they've defined:
#define EXIF_IDENT_STRING  "Exif\000\000"

which in hex would be 0x457869660030 by my count.

In the code that follows, we see:
.
.
.
                    /* The Exif APP1 marker should contain a unique identification string ("Exif\0\0"). Check for it. */
			if (!memcmp (cmarker->data, EXIF_IDENT_STRING, 6)) {
				exif_marker = cmarker;
				}
.
.
.
So, the author of the comment alluded to the correct identification string, but wasn't using it for the check. 

Since this is still in the most recent code, I'm wondering if I'm missing something, or if this is a bug.


thanks!
paul


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]