Re: Buffer overruns in gtk 1.3.12 (gdk-pixbuf)?

[Jason Tackaberry <tack auc ca>]

On Wed, 2002-01-23 at 15:27, Owen Taylor wrote:
> The fixes to pixops were not in 1.3.12. But they should have no effect
> on GDK_INTERP_NEAREST.

I just tried cvs gtk+ and the corrupt images problem persists.  I took a
screenshot of what happens:

	http://sault.org/~tack/corrupt.png

The image in question is, obviously, 000926.jpg.  The ugly part is that
the corrupted image is not because of the scale call on _that_
particular image, but rather because of a call to
gdk_pixbuf_composite_color_simple elsewhere.   I know this because if I
redraw the pixbuf (which happens if I mouse over the file) it is not
corrupt.

I can minimize this corruption by using GDK_INTERP_TILES as opposed to
GDK_INTERP_NEAREST.  And I can further reduce it by making 2 calls to
gdk_pixbuf_composite_color_simple, the first one redundant (I just
decref the first puxbuf).

It _seems_ like something is getting unallocated when it shouldn't, or
there is some kind of buffer overrun, but stability does not seem to be
affected, so I don't know.  Anyway, I'm only telling you this because
maybe you can make some sense of it -- I sure can't. :)

I'll work on a test case tomorrow or Friday.

Jason.

-- 
Academic Computing Support Specialist
Algoma University College
Sault Ste. Marie, Ontario
705-949-2301 x330                                   Personal Home Page
http://www.auc.ca                                     http://sault.org