Re: HScale vs. VScale vs. Scale w/ "orientation"



<skip pobox com> writes:
> (I think I may have asked this before.)
> 
> Is there a reason there are both HScale and VScale widgets instead of a
> single Scale widget that has an orientation parameter?  If I submitted diffs
> to make this happen (pushing most code into gtkscale.c and keeping HScale
> and VScale as stubs for backwards compatibility), would this be
> useful/accepted?  If not, are diffs to bring gtkhscale.c and gtkvscale.c
> more into sync welcome (mostly removing spurious diffs and making sure they
> make the same assertions)?  There is so much code duplication between
> between the two current scale widgets...
> 

I just rewrote these widgets, they now have basically 0 code in the
H/V subclasses and do have an orientation internally. (Though there
isn't a set_orientation() function, adding one is a 4-line change.)

Anyhow, rewrite isn't in CVS yet, but it exists.

Havoc




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]