Re: [gtk-list] [patch] range controls...




>   I also added 2 new datas in the range class:
> trough_xthickness & trough_ythickness
> These will be use to implement the different look&feels (ie win95,
> NeXT, Mui-amiga...) for range controls.
> For example a win95 or NeXT scrollbar has no (width 0) shadow on
> trough, but still has a shadow for arrows and slider.
> I modified scrollbar and scale widgets to use these datas.

I haven't seen your patch yet (still in incoming), but this doesn't
sound right. When multiple look-and-feels are implemented, that
should presumably be done using the GtkStyle mechanism. (Which will
have to be much expanded and modified.) So, I think the widget 
class structure isn't the right place for this type of thing.

Basically, I don't think we should spend much time worrying about
these things and modifying the code until we know how multiple
look-and-feels are going to be done.

(The rest of your patch sounds more reasonable, though it should
be noted that Motif scroll bars (at least) behave the way GTK
scroll bars do now, and this may be a more useful behavior
than forcing the user to move the cursor once the slider reaches
the pointer position)

Regards,
                                        Owen



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]