Re: Pango CoreText Double-Free (sort of) Crash

[Behdad Esfahbod <behdad behdad org>]

On 09/24/2012 04:21 PM, John Ralls wrote:
> I'm seeing an assert failure at pango_core_text_font_finalize() because the font->priv->fontmap is NULL.
> 
> It turns out that this is somewhat by design, as it's a weak pointer, and if the fontmap is finalized first then the weak pointer is nullified.
> 
> The obvious, trivial solution is to replace the g_assert with an if.
> 
> Is that the right thing to do?

The correct fix would be to port pangocoretext to use GWeakRef, like I did for
pangofc:

http://git.gnome.org/browse/pango/commit/?id=aca468cdc2ea66ce6dc8cfc70424a2c5309354fa

behdad