Pango CoreText Double-Free (sort of) Crash

[John Ralls <jralls ceridwen fremont ca us>]

I'm seeing an assert failure at pango_core_text_font_finalize() because the font->priv->fontmap is NULL.

It turns out that this is somewhat by design, as it's a weak pointer, and if the fontmap is finalized first then the weak pointer is nullified.

The obvious, trivial solution is to replace the g_assert with an if.

Is that the right thing to do?

Regards,
John Ralls