Re: Pango process_modules_file () module path

[John Ralls <jralls ceridwen fremont ca us>]

On Nov 4, 2012, at 4:24 PM, Behdad Esfahbod <behdad behdad org> wrote:

> Hi John,
> 
> I think Matthias / Owen better know the answer.  We used to store
> pango.modules in /etc, but I think Matthias moved it to lib (which is the
> right place anyway).  Quite possible that some places were not properly updated.

Umm, actually, it's your change [1] from last March that's the problem.

Regards,
John Ralls

[1] http://git.gnome.org/browse/pango/commit/pango/modules.c?id=ded299c755fd472bc0eb19789a1f40ab4d61a098

> 
> behdad
> 
> On 12-11-03 10:36 AM, John Ralls wrote:
>> Hey Behdad,
>> 
>> In pango/modules.c, process_modules_file() is the following phrase (line 453):
>> 
>> if (!g_path_is_absolute (tmp_buf->str)) {	
>>   const gchar *abs_file_name = g_build_filename (module_file_dir, tmp_buf->str, NULL);
>>   g_string_assign (tmp_buf, abs_file_name);
>>   g_free ((gpointer) abs_file_name);     
>> }
>> 
>> Aside from the formatting, my issue is that it's setting the path to be the same as the module file (i.e., pango.modules), which make install puts in $PREFIX/etc/pango. That isn't right, is it? Shouldn't it be setting the path to $PREFIX/lib/pango/${pango_version}/modules, which is where make install puts the modules?
>> 
>> Regards,
>> John Ralls
>> 
>> _______________________________________________
>> gtk-i18n-list mailing list
>> gtk-i18n-list gnome org
>> https://mail.gnome.org/mailman/listinfo/gtk-i18n-list
>>