Re: Pango process_modules_file () module path

[Behdad Esfahbod <behdad behdad org>]

On 12-12-18 09:04 PM, John Ralls wrote:
> 
> On Dec 18, 2012, at 5:48 PM, Behdad Esfahbod <behdad behdad org> wrote:
> 
>> On 12-12-18 08:40 PM, John Ralls wrote:
>>>
>>> On Dec 18, 2012, at 3:12 PM, Behdad Esfahbod <behdad behdad org> wrote:
>>>
>>>> On 12-11-04 11:22 PM, John Ralls wrote:
>>>>> On Nov 4, 2012, at 4:24 PM, Behdad Esfahbod <behdad behdad org> wrote:
>>>>>
>>>>>>> Hi John,
>>>>>>>
>>>>>>> I think Matthias / Owen better know the answer.  We used to store
>>>>>>> pango.modules in /etc, but I think Matthias moved it to lib (which is the
>>>>>>> right place anyway).  Quite possible that some places were not properly updated.
>>>>> Umm, actually, it's your change [1] from last March that's the problem.
>>>>
>>>> I think I pushed out a fix today.  Can you try?
>>>>
>>>
>>> That's actually a different problem than the one I was talking about (and I went ahead and fixed that one a couple of weeks ago). I'd been working around this one with PANGO_LIB_DIR, but I'll reconfigure and try this out in a couple of days.
>>
>> I see.  Ok, please just push whatever you need to fix it, as long as it's not
>> a BIG HACK.
> 
> It's
> http://git.gnome.org/browse/pango/commit/?id=69b07369009d3337b1ec2c97e397a2ece9bbab6c
> 
> I don't think it's a hack at all, it just sets the load path to lib_dir/PANGO_VERSION/modules/foo, where the modules actually get installed, instead of /etc/pango, which is where module_file_dir points to.

Ok, so it's getting more complicated.  The idea of resolving non-absolute
paths was that the path would be relative to the file being processed, which
can help in relocatability.  But what you're suggesting is different.  Let me
see if I can get my head around this.

behdad

> Regards,
> John Ralls
> 

-- 
behdad
http://behdad.org/