Re: Unimplemented functions

[Owen Taylor <otaylor redhat com>]

"Matthias Clasen" <matthiasc poet de> writes:

> While trying to  find out enough about OpenType to document
> the pango_ot_* api, I stumbled across two unimplemented functions:
> 
> void pango_ot_ruleset_set_glyph_loader   (PangoOTRuleset       *ruleset,
> 					  PangoOTGlyphLoader    func,
> 					  gpointer              data,
> 					  GDestroyNotify        notify);
> void pango_ot_ruleset_set_alternate_func (PangoOTRuleset       *ruleset,
> 					  PangoOTAlternateFunc  func,
> 					  gpointer              data,
> 					  GDestroyNotify        notify);
> 
> What is the right cause of action on these:
> 
> a) remove the declarations, since they are unlikely to be implemented
> anytime soon
> b) move the symbols to a Private subsection in pango-sections.txt to silence
> gtk-doc
> c) document the symbols as unimplemented
> d) implement them
> 
> I think a little more research would allow me to choose d). I already
> figured out that
> the right fields for these functions are TTO_GPOS->gfunc and
> TTO_GSUB->altfunc,
> now I just need to find out what to do with the destroy notify.

I'd just remove the declarations for now.

PangoOT is protected with PANGO_ENABLE_ENGINE and is meant to be
a "more evolving" API. 

The functions were in the original header design because of
TTO_GPOS->gfunc and TTO_GSUB->altfunc, but I didn't have any
particular immediate use cases for them.

Regards,
                                        Owen