Re: Thai script in Pango

[Pablo Saratxaga <pablo mandrakesoft com>]

Kaixo!

On Thu, Oct 05, 2000 at 12:13:15PM -0700, Chookij Vanatham wrote:
 
> Forget to say what I changed.
> 
> Change from tis620.2533-1 to tis620.2533-0
> Change from tis620.2529-1 to tis620.2533-0

That's wrong.
Pango must be able to use tis620 fonts that could use any of the 6 commonly 
seen X11 names:

*-tis620.2533-1
*-tis620.2533-0
*-tis620.2529-1
*-tis620.2529-0
*-iso8859-11

Removing support for one of them will surely hurt somebody somewhere.

Note also that tis620.2533-1 is what is used in latest XFree86 versions;
not tis620.2533-0.

So removing support for existing and working names is a bad thing.

> ] I downloaded Pango last month and tried it on Solaris 8.
...
> ] that gtk+-1.3.1/gtk/testtext cann't display Thai characters.

> ] get_font_info (PangoFont *font)
> ] {
> ]   static const char *charsets[] = {
> ]     "xtis620.2529-1",
> ]     "xtis-0",
> ]     "tis620.2533-1",
> ]     "tis620.2529-1",
> ]     "iso8859-11",
> ]     "iso10646-1",
> ]   };

You can however *add* "tis620.2533-0" but not remove "tis620.2533-1".
That is, change it so it has:

 get_font_info (PangoFont *font)
 {
   static const char *charsets[] = {
     "xtis620.2529-1",
     "xtis-0",
     "tis620.2533-0",
     "tis620.2533-1",
     "tis620.2529-0",
     "tis620.2529-1",
     "iso8859-11",
     "iso10646-1",
   };


   static const int charset_types[] = {
     THAI_FONT_XTIS,
     THAI_FONT_XTIS,
     THAI_FONT_TIS,
     THAI_FONT_TIS,
     THAI_FONT_TIS,
     THAI_FONT_TIS,
     THAI_FONT_TIS,
     THAI_FONT_ISO10646
   };
 
Then it will also work on Solaris (and others using *-tis620.2533-0),
but won't break it with XFree86 (and others using *-tis620.2533-1).

Thanks.

-- 
Ki ça vos våye bén,
Pablo Saratxaga

http://www.srtxg.easynet.be/		PGP Key available, key ID: 0x8F0E4975