Re: gtk+-3.9.10 build fixes for MinGW

[Erik van Pienbroek <erik vanpienbroek nl>]

Martin Schlemmer schreef op di 30-07-2013 om 16:30 [+0200]:
> Hi
>
> First two hunks (g[dt]k/Makefile.am) fixes regressions due to commits:
>
> https://git.gnome.org/browse/gtk+/commit/gdk/Makefile.am?id=d08d7f2c5a4c4c28a774119f8e1dd88e5fca1681
> https://git.gnome.org/browse/gtk+/commit/gtk/Makefile.am?id=d08d7f2c5a4c4c28a774119f8e1dd88e5fca1681

A similar patch to fix this win32 build issue was already submitted in
https://bugzilla.gnome.org/show_bug.cgi?id=700445


> The third hunk (testsuite/gtk/Makefile.am) fix a regression from commit:
>
> https://git.gnome.org/browse/gtk+/commit/testsuite/gtk/Makefile.am?id=c5e241147b6f710fcefde5d54582ea3936f48807
>
> ("defaultvalue" does not build on win32).

A fix for this one was also already submitted in
https://bugzilla.gnome.org/show_bug.cgi?id=704173


> The last hunk (modules/input/gtkimcontextime.c) fixes undefined values from "gdkkeysyms-compat.h".
> I assume the duplicate added include of "gdkkeysyms.h" from commit:
>
> https://git.gnome.org/browse/gtk+/commit/modules/input/gtkimcontextime.c?id=493ca20912a9a84b3b13f44c1e99b97eb75dd943
>
> should have been to include "gdkkeysyms-compat.h".

I wasn't aware of this issue yet (the commit in pretty recent), but I
would recommend you to create a separate patch containing this specific
snippet and propose it at bugzilla

Regards,

Erik van Pienbroek
Fedora MinGW SIG