Re: Stock Items Deprecation

["phil" <phil philandanna no-ip org>]

On 02/07/13 14:41, William Jon McCann wrote:
> Hi,
>
> As some of you may have noticed we have recently deprecated Stock Items
> in master.
>
> Some details on this change may be found here:
> https://docs.google.com/document/d/1KCVPoYQBqMbDP11tHPpjW6uaEHrvLUmcDPqKAppCY8o/pub
>
> Please let us know what you think.

The document doesn't mention anything about stock icons with rtl 
variants. I just changed some code from using the "stock-id" property of 
a GtkCellRendererPixbuf to "icon-name" and I only see the ltr versions 
of the media-playback-start icon on a rtl locale. Is it now the 
applications responsibility to take care of this by changing the icon 
name or is it just a bug? If it is now up to the application then I 
think that is (a) not a good idea as people will forget to do it and (b) 
it also needs a prominent mention in the migration guide.

As others have mentioned it is unfortunate eliminating the #defines for 
stock items also eliminates all compile-time checks for valid icon names 
& makes errors in common menu items more likely.

One other thing, I'm wondering why the migration guide and rationale are 
on goggle docs which tracks who is viewing what and which links they 
click on in the documents. It seems a bit incongruous as GNOME is 
currently fund raising for privacy enhancements and has it's own wiki.

Best Wishes

Phillip Wood