Re: Why keysym constants in gdk/gdkkeysyms.h are defined as macros, not as an enum?

On 06/27/2012 03:35 AM, Bastien Nocera wrote:
On 26 Jun 2012, at 22:56, Mark Vender <markv743 yahoo co uk> wrote:
which has no chance of negative effects. Even if we add values, they are still stored in an int, that is, GdkKeySym is never used.

If its definition is public, it will be used.

We can use an unnamed enum. E.g.

enum {

This is allowed in both C90 and C99. This will prevent from using the enum as a type.

Thus, in my opinion, even a small improvement is worthwhile.

I don't see how it improves anything. It changes things certainly, but you've yet to explain how it improves upon well tested, automated code.

It will allow gtkmm to wrap the keysyms using standard gmmproc machinery instead of a custom perl script. Also, improved consistency, enums obey scoping rules, etc., but these are not that important.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]