Re: GSignal emission optimization

[Colin Walters <walters verbum org>]

On Sun, 2011-10-02 at 03:53 +0100, Lionel Landwerlin wrote:

> Our work is available here (I'm open to suggestions to move it somewhere
> else) :
> 
> http://git.potipota.net/cgi-bin/cgit.cgi/glib/log/?h=signal-emission-speedup
> 

Please use git-bz
http://blog.fishsoup.net/2008/11/16/git-bz-bugzilla-subcommand-for-git/
to attach the patches to Bugzilla.

One comment from quick review: Please don't strip unrelated trailing
whitespace from the whole file.

> This work started on top of the glib-2-28 branch and has been rebased on
> glib-2-30. I noticed that a few things have changed on the marshallers
> generation. It seems quite a few signal moved on using a generic
> marshaller using ffi. I haven't had the time to look at it yet. Any
> information on what it does differently from old marshaller would be
> appreciated.

Yeah, you can now just pass NULL for a marshaller and GLib will do it
with ffi.  Speeding up the NULL case would benefit everyone who can take
a dependency on a newer GLib, which is necessary for your changes
anyways too, because the new generated glib-genmarshal code requires it.