Re: rendering-cleanup-next

[Kristian Rietveld <kris gtk org>]

On Sep 13, 2010, at 6:54 AM, Havoc Pennington wrote:
> On Mon, Sep 13, 2010 at 12:05 AM, John Ralls <jralls ceridwen us> wrote:
>>> Could also  make it a gdk_x11 api.
>>> But maybe a hint that is a no-op on other backends is better.
>> 
>> I'm in favor of keeping platform-specific stuff in platform-specific files and directories, but that's in large part just because I'm a bit compulsive when it comes to code organization.
>> 
> 
> Making it gdk_x11 doesn't keep the platform-specific in
> platform-specific files. It would make all files touched by
> d3802ca8331ab09fe752407577b12d1525b5d89e now include gdkx.h and an
> #ifdef'd call to the gdk_x11 API. So textview, layout, treeview,
> viewport would all now have x11-specific code.
> 
> The API need not be X specific, though the details depend on how
> Windows and Mac work and I don't know them.

I got a bit lost whether we are still going to add this API or not :)  But for what it's worth, as far as I can see now, this API is fine from an OS X point of view.  Especially with the two "conditionals" at the end of the function description there is likely enough room to do what is best suited for a given platform or to emulate the pieces that are required.


-kris.