Re: g-ir-scanner fails when using ccache

On Fri, 22 Oct 2010 11:31:20 -0400, Colin Walters  wrote:
 > On Sat, Oct 9, 2010 at 5:27 PM, Natanael Copa
<ncopa alpinelinux org> wrote:
 > > Hi,
 > >
 > > I noted that packages like dconf fails to build when CC is set to
 > > "ccache gcc". Setting it to "gcc" makes it compile. I traced it to the
 > > introspection compiler.
 > Should be fixed by
args = self._linker_cmd.split()
 args.extend(['-o', output])
Seems like that will break if _linker_cmd contains whitespace embedded
in the pathname. I know lots of unixoid code isn't safe for this sort
of situation, and "does the whitespace mean delimiter-between-words vs
word-with-whitespaces?" is painful especially in shell-related
handlers. And it seems more important to handle a common situation
(wrappers and other multi-word 'compiler's) on all platforms than a
rarer situation that probably causes tons of problems for all programs.
Might want to document this limitation somewhere (since it's a *new*
one based on this change).
Daniel Macks
 dmacks netspace org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]