Re: impending gdbus merge


I have just a few remarks/questions after having ported a couple of
things to gdbus, and having looked at the API:

- g_bus_own_name has a _on_connection variant that directly takes a
  GDBusConnection*; maybe g_bus_watch_name and g_bus_watch_proxy
  shoule also have such a variant.

- timeouts in g_dbus_connection_call[_sync] etc are in ms and default
  to 30000 ms. Does it really matter if the timeout is exact here, or
  just 30s-ish ? I'd suggest to make these timeout parameters take
  seconds instead, and use the sloppy glib timeouts. (If there really is
  a use case for exact timeouts, maybe a call flag like
  G_DBUS_CALL_PRECISE_TIMEOUT could be added that makes these timeouts
  interpreted as ms and use precise glib timeouts.)

- should g_bus_unwatch_name/proxy call the name/proxy_disappeared
  callbacks, if the name/proxy_appeared callbacks have been called
  before? It appears they don't. (I checked the watch_name one; I
  assume watch_proxy is the same?) It would be nice not to have to
  manually clean up after calling unwatch, when I also do the same in
  the disappeared-callback.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]