Re: Some questions regarding _gdk_window_impl_new() (csw, win32, patch)

[Alexander Larsson <alexl redhat com>]

On Sun, 2010-08-29 at 14:34 +0200, Hans Breuer wrote:
> At 27.08.2010 22:41, Hans Breuer wrote:
> > At 24.08.2010 10:14, Alexander Larsson wrote:
> >> On Sat, 2010-08-21 at 14:09 +0200, Hans Breuer wrote:
> [...]
> >>> - if the information given to _gdk_window_impl_new() is redundant,
> >>> as with GDK_WA_VISUAL set and visual given by parameter, which one
> >>> has precedence?
> >>
> >> Use the visual parameter, it is based on GDK_WA_VISUAL if set already.
> > So I could assert on it ...
> >
> >> From attributes the only things used is: colormap, title, wmclass and
> >> type_hint.
> >>
> Unfortunately also wclass is not always set and the backend code was still 
> relying on it. Even _gdk_offscreen_window_new() does use wclass without 
> check, though that does not matter in this case because the culprit is 
> gdk_window_ensure_native().
> Maybe some of 
> https://bugzilla.gnome.org/review?bug=628049&attachment=168824 should be 
> applied?

Yes, at least the wclass should be set like that. Can you commit that?

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl redhat com            alexander larsson gmail com 
He's a Nobel prize-winning chivalrous cowboy on the edge. She's a foxy snooty 
journalist fleeing from a Satanic cult. They fight crime!