Re: [directfb-dev] GDK-DirectFB Patches

[Denis Oliver Kropp <dok directfb org>]

Attilio Fiandrotti wrote:
> Attilio Fiandrotti wrote:
>> Denis Oliver Kropp wrote:
>>> Attilio Fiandrotti wrote:
>>>> Yesterday i noticed the very same issue Reny spotted (even without the 
>>>> HACK files).
>>>> So my idea is committing the single gdkevens patch now and wait some 
>>>> more before applying the last set of patches proposed by dok, os that 
>>>> those issues can be adressed properly.
>>> Do problems exist if you leave out the hacks and the rgb16 patch?
>> If i leave out the rgb16 patch, the problem disappears and everything 
>> works fine as before.
>>
>> I just committed your previous patch for gdk events in trunk and 
>> gtk-2-10, only to discover it causes a crash on toplevel window closing 
>> (META + C), i'll try to fix it.
> 
> I just verified that the GdkDirectFB patch alone doesn't cause the bug, 
> so its recent commit was ok.
> The bug i ran into (try closing the "icon view basic" window in 
> gtk-demo, trace attached) was istead caused by window_flip_group.patch 
> and is triggered only when NO_EXPERIMENTS is *not* defined, otherwise 
> the patch is ok.

Sure, NO_EXPERIMENTS should disable all changes :)

> I'll do more testing tomorrows.
> 
> Attilio
> 
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0xb75b76b0 (LWP 29606)]
> 0xb7f57dfd in IA__gdk_window_get_toplevel (window=0x837c0e0) at 
> gdkwindow.c:617
> 617       while (GDK_WINDOW_TYPE (obj) == GDK_WINDOW_CHILD)
> (gdb) bt
> #0  0xb7f57dfd in IA__gdk_window_get_toplevel (window=0x837c0e0) at 
> gdkwindow.c:617

Just a segfault? Did you build with G_DISABLE_CHECKS or G_DISABLE_CAST_CHECKS?

> #1  0xb7f6f41c in gdk_window_directfb_process_all_updates () at 
> gdkwindow-directfb.c:105
> #2  0xb7f6f4d7 in gdk_window_update_idle (data=0x0) at 
> gdkwindow-directfb.c:134
> #3  0xb7f39b4f in gdk_threads_dispatch (data=0x838e760) at gdk.c:470
> #4  0xb78d7661 in ?? () from /usr/lib/libglib-2.0.so.0

I guess it's a reference counting problem. I'll try to fix it. Thanks for testing!

-- 
Best regards,
  Denis Oliver Kropp

.------------------------------------------.
| DirectFB - Hardware accelerated graphics |
| http://www.directfb.org/                 |
"------------------------------------------"