On Wed, 05 Dec 2007 11:09:33 +0100, Denis Oliver Kropp wrote: > > CAIRO-DIRECTFB: Use DirectFB for show_glyphs() even if it is unaccelerated. > > The software fallback in DirectFB is well optimized. Hi Denis, I'm inclined to let anyone who wants to maintain cairo-directfb-surface.c do whatever they feel is best to it. But could you please send proposed patches to the cairo mailing list? There are probably cairo-directfb maintainers there that will want to review this. > -#if DFB_SHOW_GLYPHS > +#if DFB_SHOW_GLYPHS && 0 > if (!(dsc.acceleration_mask & DFXL_BLIT) || > !(dsc.blitting_flags & DSBLIT_COLORIZE) || > !(dsc.blitting_flags & DSBLIT_BLEND_ALPHACHANNEL)) Why leave this code around? If it's truly not wanted, it would be cleaner to remove it. -Carl
Attachment:
pgp3piydW9P5h.pgp
Description: PGP signature