Re: [RFC] Simple file monitoring API for GLib

[Emmanuele Bassi <ebassi gmail com>]

Hi Matthias,

On Mon, 2006-05-08 at 20:54 -0400, Matthias Clasen wrote:
> On 5/8/06, Emmanuele Bassi <ebassi gmail com> wrote:
> 
> [...]
> 
> > The file monitoring API is as simple as the current API for idle and
> > timeout sources:
> 
> [...]
> 
> General comments:
> 
> - In general, I like the proposed API.
> 
> - I wonder if we need the extension hooks at all. Assuming we have
>   implementations using inotify and whatever the native file monitoring
>   apis on win32 or OS X are, you don't actually win anything by replacing
>   the builtin implementation by, e.g, gnome-vfs...

The extension would be useful while we don't have platform-depended
implementations, or to override the implementations at run-time, instead
of compile time.

> Comments on the patch:
> 
> - The docs for add_full make it sound as if a custom backend could
>   add support for remote file monitoring, but that is not the case.

Yep, my mistake.

> - If we do find the extension api necessary, set_hooks should probably
>   warn if it is called "too late".

Okay.

Ciao,
 Emmanuele.

-- 
Emmanuele Bassi - <ebassi gmail com>
Log: http://log.emmanuelebassi.net