Re: locking around source_funcs->finalize

["Matthias Clasen" <matthias clasen gmail com>]

On 6/2/06, Tim Janik <timj imendio com> wrote:
> hi Owen.
>
> reading up on g_source_unref() again, i notice that the
> GMainContext lock is removed and re-acquired around
> callback_funcs->unref(), but not around source_funcs->finalize();
> supposing you're unlocking around unref() so that the
> handler may do things like adding a new idle handler
> to the context, shouldnt the same semantics be provided
> for source_funcs->finalize() as well?

Interesting observation Tim.

We actually ran into a deadlock in the gtk print module code
where a source finalize function was trying to add another idle...
So fixing this would help GTK+; it would allow us to unload
the print backends.

Matthias