Re: A cross-platform status icon api

[Hans Breuer <hans breuer org>]

On 04.09.2005 22:59, Matthias Clasen wrote:
> On Sun, 2005-09-04 at 15:27 +0200, Hans Breuer wrote:
>
> > On 30.08.2005 00:37, Matthias Clasen wrote:
> > [...]
> >
> > > cvs as of today has
> >
> > Trying to make it compile on win32 implies that two files
> > should be renamed :
> >
> > gtkstatusicon-x11.c has nothing X11 specific in it. At least
> > it compiles on win32 without any change. So it probably should
> > be named gtkstatusicon.c
> >
> > gtktrayicon.c is highly X11 dependent so it should be
> > called gtktrayicon-x11.c
> >
> > I have done the renaming in my local tree and also created
> > a currently empty implementation of gtktrayicon-win32.c.
> > With it HEAD could be compiled again on win32.
>
>
> No, this is backwards. gtkstatusicon-x11.c is named like it is because
> it is the X11-specific implementation of the statusicon api. 
Yeah, trying to implement something with it I noticed that, too.

> gtktrayicon.c may compile on win32, but that is completely irrelevant, 
     ^^^^^
gtkstatusicon-x11 does, gtktrayicon.c does *not*. How do you suggest to
call the win32 specific file ?

> since we want to use native win32 apis for status icons here, not the
> freedesktop.org system tray specification, that is implemented in
> gtktrayicon.c. 

> There is no need to name the file gtktrayicon-x11.c,
> since there will not be a gtktrayicon-win32.c (you can't embed
> widgets into the win32 notification area).
I know. But the name is still misleading.

Also gtkstatusicon-x11.c not only implements the fdo spec but it also
defines a bunch of status icon api. Not only 21 functions but additionally
quite some properties. Should all this be duplicated to get the
cross-platform status api ?

Thanks,
	Hans

-------- Hans "at" Breuer "dot" Org -----------
Tell me what you need, and I'll tell you how to
get along without it.                -- Dilbert