Re: g_file_write()

On Sun, 6 Mar 2005, Soeren Sandmann wrote:

> Is it useful to add g_file_write() to complement
> g_file_get_contents()? It seems a feature many applications could use.
> Patch attached (not tested on Windows). It is also available at

Just some quick comments on the patch:

- Why not use g_fopen (and drop the g_utf8_to_utf16 thing)? This makes it
  more likely to work well on Windows

- Shouldn't you free normalized_filename and display_filename also when
  the function completes successfully?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]