Re: A new type of pango underlining for underlining errors

[Havoc Pennington <hp redhat com>]

Hi,

General comments - 
 - should the underline be called something like UNDERLINE_ERROR to 
   reflect that it's not just wavy but red, and generally supposed to 
   indicate an error (what do Java/WinForms name this kind of 
   underline?)
 - it looks like it's only red in the textview; maybe it needs to 
   be red everywhere?

One detail - 
 - should use gdk_gc_set_rgb_fg_color() instead of allocating the color

Havoc