Re: A new type of pango underlining for underlining errors

[Owen Taylor <otaylor redhat com>]

On Thu, 2003-10-30 at 12:57, Nicolas Setton wrote:
> > >   * Are there plans currently to integrate this ?
> > 
> > http://bugzilla.gnome.org/show_bug.cgi?id=114237
> 
> Thanks. This is exactly what we want.
> 
> > >   * Would you be interested by an external contribution at this stage ?
> > 
> > Yes.
> 
> I have started to look at the code in pango and gtk, it seems pretty
> straightforward to add a new underline type (is "PANGO_UNDERLINE_WAVE" a
> good name?), but I have one more question:
> 
>  * Where would the gdk_gc corresponding to the "red" color be
> created/stored ? Is it OK to store it in the GtkTextRenderState that is
> created and destroyed in gtk_text_layout_draw ?

I think that's fine -- keeps things simple for now.

(See bug 73310 for what you'd need to cache the GC in the style)

Regards,
							Owen