Re: gtk_container_forall()

[Tim Janik <timj gtk org>]

On 21 Sep 2001, Owen Taylor wrote:

> 
> gtk_container_forall() is currently listed in the:
> 
>  /* Non-public methods */
> 
> Sections of gtkcontainer.h. I'm currently going through
> gtkcontainer.h and _prefixing the non-public methods,
> but I'm not sure that doing so for gtk_container_forall()
> makes sense; 
> 
>  - There doesn't seem to be anything particularly,
>    private about it, though must public cases will want
>    gtk_container_foreach. Since we require containers to
>    implement the ::forall signal, we can't say that this
>    is some internal detail that nobody should ever see.
> 
>  - It is currently used in a handful of places external
>    to GTK+. (http://cvs.gnome.org/lxr/ident?i=gtk_container_forall 
>    gives some.) Many of these could probably use foreach()
>    but I'm not sure _all_ could.
> 
>  - gtk_container_forall() might actually be useful for 
>    things like gui builders, accessibility tools, 
>    debugging tools, and the kind of bad hacks that every
>    sufficiently complex app will eventualy need.

yes, it shouldn't be "_" prefixed. the "internal" there was added before
we started to "_" prefix all functions flaged as such. this one is not
strictly internal in that extern apps shouldn't be able to use it,
theme engines glade or gle are good examples which still require _forall.

> 
> Regards,
>                                         Owen
> 

---
ciaoTJ