Re: Proposed fix for bug 53612 (KEYNAV:GtkNotebook)

["Padraig O'Briain" <Padraig Obriain Sun COM>]

I have not received any comments on this mail. I would appreciate it if the 
proposed changes could be reviewed so I would know whether I am on the right 
track before working on the other KEYNAV bugs.

Padraig

> Delivered-To: gtk-devel-list gnome org
> Subject: Proposed fix for bug 53612 (KEYNAV:GtkNotebook)
> To: gtk-devel-list gnome org
> MIME-Version: 1.0
> X-BeenThere: gtk-devel-list gnome org
> X-Loop: gtk-devel-list gnome org
> X-Mailman-Version: 2.0.5
> List-Help: <mailto:gtk-devel-list-request gnome org?subject=help>
> List-Post: <mailto:gtk-devel-list gnome org>
> List-Subscribe: <http://mail.gnome.org/mailman/listinfo/gtk-devel-list>, 
<mailto:gtk-devel-list-request gnome org?subject=subscribe>
> List-Id: Development of GTK+ <gtk-devel-list.gnome.org>
> List-Unsubscribe: <http://mail.gnome.org/mailman/listinfo/gtk-devel-list>, 
<mailto:gtk-devel-list-request gnome org?subject=unsubscribe>
> List-Archive: <http://mail.gnome.org/archives/gtk-devel-list/>
> 
> Bug 53612 identifies four changes to the operation of GtkNotebook:
> 
> 1) If any control on the frontmost page of the notebook (including its page
> label) has focus, Ctrl+Tab (*) should move focus to the first control after
> the notebook.
> 
> If any control on the frontmost page of the notebook (including its page
> label) has focus, Shift+Ctrl+Tab should move focus to the last control
> before the notebook.
> 
> 2) When any control in the notebook has focus (including any page label),
> Ctrl+PgUp should bring the next tab to the front, and Ctrl+PgDn should
> bring the previous tab to the front.  In either case, the control on the
> new frontmost page that last had focus is given focus again.
> 
> 3) When any page label has focus, pressing Tab or Ctrl+down arrow should
> give focus to the first control on that page, bringing the selected page to
> the front if necessary.
> 
> 4) When any control on the frontmost page has focus, pressing Ctrl+up arrow
> should give focus to that page's label.
> 
> I have attempted to address these issues withe the attached patch.
> For 1), 2) and 4) a signal move_focus_out, move_focus_page, move_focus_up 
> is defined for the required operation and if an ancestor of the focus
> widget supports the required operation it happens.
> For 3) a signal move_focus and key bindings are defined in gtknotebook.c 
> to implement the operation.
> 
> What changes are needed before this change can be committed?
> 
> Padraig
>