Re: patches for make dist on clean checkout (glib, pango, gtk+)
- From: jacob berkman <jacob ximian com>
- To: Tim Janik <timj gtk org>
- Cc: Gtk+ Developers <gtk-devel-list gnome org>, Owen Taylor <otaylor redhat com>
- Subject: Re: patches for make dist on clean checkout (glib, pango, gtk+)
- Date: 29 Oct 2001 09:29:14 -0500
On Mon, 2001-10-29 at 05:36, Tim Janik wrote:
> On 28 Oct 2001, jacob berkman wrote:
> > these patches seemed to have fallen through the cracks.
> > they make glib, pango, and gtk+ able to "make dist" without being
> > previously built (which is needed by my snapshots and generally not a
> > bad idea).
> i don't see how that could possibly work, as make dist
> requires source files which only get created during the build process.
that is what the patch does - it builds those files by adding a
dependency on the built files to the docs that require them.
and it *does* actually work, as i've been using these patches to build
automated tarballs from cvs for 2-3 weeks.
> > are there any problems with them left?
> yep, i have no idea what your changes mean to accomplish.
> for example, could you outline what the following:
> Index: glib/gobject/Makefile.am
> RCS file: /cvs/gnome/glib/gobject/Makefile.am,v
> retrieving revision 1.40
> diff -u -r1.40 Makefile.am
> --- glib/gobject/Makefile.am 2001/09/25 06:03:22 1.40
> +++ glib/gobject/Makefile.am 2001/10/28 16:17:43
> @@ -14,6 +14,14 @@
> libglib = $(top_builddir)/glib/libglib-1.3.la
> +$(libglib): update-libglib
> + @true
> + @cd $(top_builddir)/glib && $(MAKE) $(AM_MAKEFLAGS)
> +.PHONY: update-libglib
> # libraries to compile and install
> lib_LTLIBRARIES = libgobject-1.3.la
> is supposed to do?
it fixes this error:
make: *** No rule to make target `../glib/libglib-1.3.la', needed by
make: Leaving directory `/home/jacob/gnomecvs/glib/gobject'
make: *** [distdir] Error 1
> i see no point in having a replacement for
> $ cd /usr/src/glib ; make
> which looks like:
> $ cd /usr/src/glib/gobject ; make
another alternative is for glib to just build libglib itself at distdir
> in general, there's no point in even attempting such a patch,
> dist-checking glib/pango/atk/gtk simply requires a full fledged
> build setup, such as perl/gtk-doc/X-connection etc, as a significant
> portion of the reusulting tarballs is created from information that
> is only accessible during runtime of a gtk program.
well this isn't distchecking, just disting. and an X connection is no
longer required after what i committed yesterday. and a full fledged
build setup is exactly what i'm working with. (the perl/gtk-doc setup is
not difficult to get. for some reason red hat ships one that works by
"Beat mixing is 10000 times more fun than even video games."
] [Thread Prev