Re: patches for make dist on clean checkout (glib, pango, gtk+)



On 28 Oct 2001, jacob berkman wrote:

> these patches seemed to have fallen through the cracks.
> 
> they make glib, pango, and gtk+ able to "make dist" without being
> previously built (which is needed by my snapshots and generally not a
> bad idea).

i don't see how that could possibly work, as make dist
requires source files which only get created during the build process.


> 
> are there any problems with them left?

yep, i have no idea what your changes mean to accomplish.
for example, could you outline what the following:

Index: glib/gobject/Makefile.am
===================================================================
RCS file: /cvs/gnome/glib/gobject/Makefile.am,v
retrieving revision 1.40
diff -u -r1.40 Makefile.am
--- glib/gobject/Makefile.am    2001/09/25 06:03:22     1.40
+++ glib/gobject/Makefile.am    2001/10/28 16:17:43
@@ -14,6 +14,14 @@
 
 libglib = $(top_builddir)/glib/libglib-1.3.la
 
+$(libglib): update-libglib
+       @true
+
+update-libglib:
+       @cd $(top_builddir)/glib && $(MAKE) $(AM_MAKEFLAGS)
+
+.PHONY: update-libglib
+
 # libraries to compile and install
 lib_LTLIBRARIES = libgobject-1.3.la
 

is supposed to do?
i see no point in having a replacement for
$ cd /usr/src/glib ; make
which looks like:
$ cd /usr/src/glib/gobject ; make


in general, there's no point in even attempting such a patch,
dist-checking glib/pango/atk/gtk simply requires a full fledged
build setup, such as perl/gtk-doc/X-connection etc, as a significant
portion of the reusulting tarballs is created from information that
is only accessible during runtime of a gtk program.

> 
> jacob
> -- 
> "Beat mixing is 10000 times more fun than even video games."
> 	-- bt
> 

---
ciaoTJ




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]