Re: gtkfontsel.c (gtk_font_selection_set_name)

[Owen Taylor <otaylor redhat com>]

Michael Meeks <michael ximian com> writes:

> On Tue, 9 Oct 2001, Michael Meeks wrote:
> > 	This method needs a precondition on the name, or it dies in
> > strcasecmp, may I commit ?
> 
> 	Doh; I'm a dofus - it doesn't; but something needs to be done
> about pango_font_description_get_family returning NULL into the
> strcasecmp; eg. for pango_font_description_from_string ("") on my system.

I think the simple approach of:

 family = pango_font_description_get_family (new_desc);
 g_return_if_fail (family != NULL);

Should be fine. Feel free to commit such a change.

Regards,
                                        Owen