Re: window state stuff
- From: Tim Janik <timj gtk org>
- To: Owen Taylor <otaylor redhat com>
- Cc: Gtk+ Developers <gtk-devel-list gnome org>
- Subject: Re: window state stuff
- Date: Thu, 1 Mar 2001 01:53:34 +0100 (CET)
On 23 Feb 2001, Owen Taylor wrote:
> > make this function public, progs like the tasklist prolly want to use it.
> > also it should be named _gdk_wmspec_supports() since you actively use it
> > for repetitive checks throughout the code.
>
> I'm not sure what the principle is here that would suggest that...
>
> [ wmspec_supported is pretty clearly an abbreviation for
> wmspec_is_supported() rather than wmspec_was_supported()... ]
right, an abbreviation like e.g. g_module_supported().
however, the difference is that g_module_supported() checks whether
GModule "is supported", while gdk_wmspec_supported(atom) actually
checks whether the current window manager supports the passed in wmspec
atom. so unless that function was meant to be
gboolean gdk_wmspec_supported (void);
which is obviously not the case, it should be renamed to
gboolean gdk_wmspec_supports (atom_to_support);
>
> Owen
>
---
ciaoTJ
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]