Re: window state stuff

[Owen Taylor <otaylor redhat com>]

Tim Janik <timj gtk org> writes:

> On 23 Feb 2001, Owen Taylor wrote:
> 
> > > make this function public, progs like the tasklist prolly want to use it.
> > > also it should be named _gdk_wmspec_supports() since you actively use it
> > > for repetitive checks throughout the code.
> > 
> > I'm not sure what the principle is here that would suggest that...
> > 
> > [ wmspec_supported is pretty clearly an abbreviation for 
> >   wmspec_is_supported() rather than wmspec_was_supported()... ]
> 
> right, an abbreviation like e.g. g_module_supported().
> however, the difference is that g_module_supported() checks whether
> GModule "is supported", while gdk_wmspec_supported(atom) actually
> checks whether the current window manager supports the passed in wmspec
> atom. so unless that function was meant to be
> gboolean gdk_wmspec_supported (void);
> which is obviously not the case, it should be renamed to
> gboolean gdk_wmspec_supports (atom_to_support);

OK, I hadn't realized that there was the atom argument

How about:

 gdk_net_wm_supports ()

Making it clear that it is the window manager, not the spec which
might support the functionality. And include "net" to indicate
which wm spec.

Regards,
                                        Owen