Re: PATCH: glib iochannel win32 bug fix



Ron Steinke <rsteinke w-link net> writes:

> > From: "Andrew J. Lanoix" <alanoix umich edu>
> >
> > Ron,
> > Well, I can't figure out how to apply the patches so go ahead and commit 
> > them. Looking through I can see that you are changing some return values in 
> > giowin32.c without specifying anything to be returned.
> 
> It's just a CVS diff. Changing into the glib directory and using
> patch -p1 works for me. Commiting is up to Owen.
> 
> The return values changed due to a need to support the new API
> error handling in the backend. If you can specify any functions
> which should be returning something and aren't (or find any other bugs),
> I'd be happy to hear them.

Please don't commit ... I've sent Ron a number of comments on the
other parts of the patch, and I'd like to get those fixed before
it is committed to CVS. 

(Changes to make giowin32.c compile are OK - but the other need
to wait a bit.)

Regards,
                                        Owen




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]