Re: a couple of small bugs

[James Henstridge <james daa com au>]

On 6 Aug 2001, Owen Taylor wrote:

>
> James Henstridge <james daa com au> writes:
>
> > I just put patches for two small gtk+ bugs in bugzilla:
> >   http://bugzilla.gnome.org/show_bug.cgi?id=58615
> >   http://bugzilla.gnome.org/show_bug.cgi?id=58628
> >
> > The first fixes a bug with the positioning of the children in GtkToolbar
> > widgets.  The size_allocate routine uses twice as much padding to the left
> > of the children (top for vertical toolbars), making the last child flush
> > against the edge of the toolbar which makes it overwrite the bevel.
>
> Traditionally buttons in a GtkToolbar have been positioned _over_
> the bevel; while a little odd, this prevents having a double bevel
> with both the buttons and the bevel.
>
> I think the way it is supposed to work is that the internal-padding
> parameter should control how much the buttons overlap the bevel.
> When it is 0, as it is by default, the buttons should be flush with
> edge of the widget.

Well, the way it is at the moment, there is a big space before the first
button, and the last button overlaps the right hand edge of the bevel,
which is almost definitely wrong.

With the patch applied, the amount of padding to the left of the first
button and right of the last button is equal, which looks like what the
existing code is trying to do.  It looks a lot closer to the gtk 1.2
toolbar with the patch applied.

>
> > The second makes the GtkAccelLabel refetch its accelerator when
> > gtk_accel_label_set_accel_object() is called.  Without this, the accel
> > label won't show the correct results until an add-accelerator or
> > remove-accelerator signal is emitted on the watched object.
>
> The only change I'd do here is refetch before you notify on the
> property change, so a listener sees the new correct values.

okay.

>
> > Both patches are fairly obvious and don't affect the API.  Okay to commit?
>
> Well, we need to figure out how the toolbar is supposed to work,
> but it sounds like some fix is needed. The other patch looks
> fine, with the above comment.

okay.  Just applied the accel label patch with the refetch before the
notify.

James.

-- 
Email: james daa com au
WWW:   http://www.daa.com.au/~james/