Re: a couple of small bugs

[Owen Taylor <otaylor redhat com>]

James Henstridge <james daa com au> writes:

> I just put patches for two small gtk+ bugs in bugzilla:
>   http://bugzilla.gnome.org/show_bug.cgi?id=58615
>   http://bugzilla.gnome.org/show_bug.cgi?id=58628
> 
> The first fixes a bug with the positioning of the children in GtkToolbar
> widgets.  The size_allocate routine uses twice as much padding to the left
> of the children (top for vertical toolbars), making the last child flush
> against the edge of the toolbar which makes it overwrite the bevel.

Traditionally buttons in a GtkToolbar have been positioned _over_ 
the bevel; while a little odd, this prevents having a double bevel
with both the buttons and the bevel.

I think the way it is supposed to work is that the internal-padding
parameter should control how much the buttons overlap the bevel.
When it is 0, as it is by default, the buttons should be flush with
edge of the widget.
 
> The second makes the GtkAccelLabel refetch its accelerator when
> gtk_accel_label_set_accel_object() is called.  Without this, the accel
> label won't show the correct results until an add-accelerator or
> remove-accelerator signal is emitted on the watched object.

The only change I'd do here is refetch before you notify on the
property change, so a listener sees the new correct values.
 
> Both patches are fairly obvious and don't affect the API.  Okay to commit?

Well, we need to figure out how the toolbar is supposed to work,
but it sounds like some fix is needed. The other patch looks
fine, with the above comment.

Regards,
                                        Owen