pending stuff in havoc-patches


Some of this has been posted before, some might be new, I don't
remember everything. I forgot to tag HEAD when branching
havoc-patches, which is causing me pain.


Outstanding questions so I can finish this:

  - Should SHORT_LIVED, PERSISTENT, etc. be GtkWindow flags? 
    (These are semantic "types" of window, so we can make
    GTK_WIN_POS_MOUSE etc. user-configurable)

  - Should gtk_dialog_run() return only when the widget is hidden, 
    or also when "action" is emitted? 

  - Is it OK to break old code with a default delete_event 
    handler in GtkDialog that hides the dialog instead of destroying it? 
    (This breakage is required in order to permit the
    only-hide-on-click behavior, otherwise gtk_dialog_run() can result
    in a dialog with an unknown reference count that might be 0)

  - Do we want the gtk_dialog_action() signal-emission function

Already-agreed-upon changes in gtkdialog.[hc]:
  - remove add/remove handlers on action area
  - virtualize add_action

I haven't done these yet, I'll do all the changes at once after I know
the full set of changes.

A convenience widget that:

  - sets title automatically 
  - sets buttons/action_id automatically 
  - packs a label 
  - packs a big question mark icon or whatever 

Qt, Motif, etc. all have this widget, I think it's useful. 
Need a yes/no on its inclusion.


I hacked it to allow a context_id of 0; this is only a matter of
removing g_return_if_fail(). The purpose of the change is to allow
using the statusbar without worrying about get_context_id(), etc.
Here's that patch:

Index: gtkstatusbar.c
RCS file: /cvs/gnome/gtk+/gtk/gtkstatusbar.c,v
retrieving revision 1.20
retrieving revision
diff -u -r1.20 -r1.20.2.1
--- gtkstatusbar.c      2000/02/13 08:16:47     1.20
+++ gtkstatusbar.c      2000/03/30 02:22:47
@@ -204,7 +204,6 @@
   g_return_val_if_fail (statusbar != NULL, 0);
   g_return_val_if_fail (GTK_IS_STATUSBAR (statusbar), 0);
   g_return_val_if_fail (text != NULL, 0);
-  g_return_val_if_fail (context_id > 0, 0);
   class = GTK_STATUSBAR_CLASS (GTK_OBJECT (statusbar)->klass);
   msg = g_chunk_new (GtkStatusbarMsg, class->messages_mem_chunk);
@@ -230,7 +229,6 @@
   g_return_if_fail (statusbar != NULL);
   g_return_if_fail (GTK_IS_STATUSBAR (statusbar));
-  g_return_if_fail (context_id > 0);
   if (statusbar->messages)
@@ -273,7 +271,6 @@
   g_return_if_fail (statusbar != NULL);
   g_return_if_fail (GTK_IS_STATUSBAR (statusbar));
-  g_return_if_fail (context_id > 0);
   g_return_if_fail (message_id > 0);

Stock system

This consists of gtkstock.h, gtkiconset.h in the havoc-patches branch.
Needs comment.

(the StockFactory should be a GObject, and IconSet should be copy/free
instead of refcounted, for language bindings - will fix this)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]