Re: GTK+ 2.8.0 released

[Owen Taylor <otaylor redhat com>]

On Sun, 2005-08-14 at 19:50 -0400, Allin Cottrell wrote:
> On Sat, 13 Aug 2005, Matthias Clasen wrote:
>
> > Release notes are available at:
> >
> > http://www.gtk.org/gtk-2.8.0-notes.html
>
> These notes speak of a "Pango 1.10".  Has this been released 
> anywhere?

No. Hopefully later today.

> It would be nice to have the new cairo/pixman dependency properly 
> registered via pkgconfig.  The Gtk dependencies directory contains 
> cairo but not libpixman.  Cairo builds and installs OK without 
> pixman, but then the pango (1.9.1) build fails for lack of pixman 
> (though this is not flagged by configure).

It's just an example, so you can 'make -k', 'make -k install'. There's
a fix in Pango CVS for the issue.

> One further compatibility issue: the app that I have built and run 
> OK (without warnings) using gtk 2.6, now shouts repeatedly, when 
> built against 2.8:
>
> Gdk-CRITICAL **: gdk_drawable_get_colormap: assertion 
> `GDK_IS_DRAWABLE (drawable)' failed
>
> Gdk-WARNING **: gdk_window_set_back_pixmap(): pixmap must have a 
> colormap
>
> Any suggestions what's going on here?

Uck. That will teach me to make last minute changes.

Fixed in CVS with the following change.

Thanks for pointing it out,
                                                        Owen

2005-08-15  Owen Taylor  <otaylor redhat com>

        * gdk/linux-fb/gdkwindow-fb.c (gdk_window_set_back_pixmap):
        * gdk/win32/gdkwindow-win32.c (gdk_window_set_back_pixmap):
        * gdk/x11/gdkwindow-x11.c (gdk_window_set_back_pixmap):
        Handle pixmap == NULL when checking for a colormap.
        (Allin Cottrell).

--- gdk/x11/gdkwindow-x11.c     12 Aug 2005 13:13:54 -0000      1.247
+++ gdk/x11/gdkwindow-x11.c     15 Aug 2005 12:34:49 -0000
@@ -2913,7 +2913,7 @@ gdk_window_set_back_pixmap (GdkWindow *w
   g_return_if_fail (pixmap == NULL || !parent_relative);
   g_return_if_fail (pixmap == NULL || gdk_drawable_get_depth (window) == gdk_drawable_get_depth (pixmap));

-  if (!gdk_drawable_get_colormap (pixmap))
+  if (pixmap && !gdk_drawable_get_colormap (pixmap))
     {
       g_warning ("gdk_window_set_back_pixmap(): pixmap must have a colormap");
       return;