Re: should I ref/strdup values in my _set_property() method



done, as
http://bugzilla.gnome.org/show_bug.cgi?id=153623


Owen Taylor wrote:
On Thu, 2004-09-23 at 16:42 +0200, Stefan Kost wrote:

The one I still have open is
gdk/gdkdisplaymanager.c:141

default_display = g_value_get_object (value);

Anyway I will take some time on this weekend to study it deeper, for writing it
all down for the GObject tutorial.


Looks like a bug, filing in bugzilla would be good.

(Actually, display memory management is a little different, so perhaps
it should be a weak reference, not a strong one. But in any case,
it's not calling _gdk_windowing_set_default_display(), so it's
buggy as compared to gdk_display_manager_set_default_display(),
which it should be calling.)

Regards,
                                      Owen


-- 
      \|/            Stefan Kost
     <@ @>           private            business
+-oOO-(_)-OOo------------------------------------------------------ - - -  -   -
|       __  Address  Simildenstr. 5     HTWK Leipzig, Fb IMN, Postfach 301166
|      ///           04277 Leipzig      04251 Leipzig
| __  ///            Germany            Germany
| \\\///    Phone    +49341 2253538     +49341 30766101
|  \__/     EMail    st_kost_at_gmx.net kost_at_imn.htwk-leipzig.de
|           WWW      www.sonicpulse.de  www.imn.htwk-leipzig.de/~kost/about.html
===-=-=--=---=---------------------------------- - - -  -    -


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]