Re: Browsing in UPnP plugin

["Juan A. Suarez Romero" <jasuarez igalia com>]

On Thu, 2013-08-15 at 17:43 +0200, Jens Georg wrote:
> Hi,
>
> on servers that support "Search" the UPnP plugin uses it to do the
> browsing instead of doing "Browse". This is completely legitimate,
> however I spotted an "issue":
>
> The search uses "@parentID = someId" and then the search is executed on
> that container "someId" so this is a bit redundant - is this
> intentional?

I think so.

When you perform a search in a container, are all the subcontainers also
searched? Because we want to restrict the search only to one specific
container, and not for the children. That's why we added the @parentID
filter.

> BTW, the plug-in does not check whether the container is actually
> searchable and has matching <searchClass> entries; DLNA for example only
> requires the top-level container to be searchable if "Search" is
> supported.

I think it is done in function gupnp_search_caps_cb. Though maybe it is
incorrect.

        J.A.