Re: [PATCH 3/6] core: made plugin registry handle itself key id assignments



On Thu, 12 May 2011 16:02:27 +0200, Guillaume Emont 
<guijemont igalia com> wrote:
On 12/05/2011 15:27, Iago Toral wrote:

Aha, I see. Thanks for explaining.
Also, do you have more comments? Did you get to review the patchset
thoroughly? Note that this patchset goes with the one on grilo-plugins
as well.

I have addressed your changes and the new version is availble there:

https://www.gitorious.org/~guijemont/grilo/guijemont-sandbox/commits/refactor-grlkeyid
Will wait for your answer before I send the new version to the mailing
list, if that's needed.
I reviewed all the patches and did not find any more issues than the 
minor things I mentioned, however I apply / test them myself but you 
already did this so I don't think we should wait for me to do that. I 
also checked the grilo-plugins patchset and those changes are trivial, 
so no comments.
In summary, feel free to go ahead and push the changes if you consider 
you have done enough testing.
Iago



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]