Re: [PATCH 01/14] tracker: make query requests asynchronous

[Lionel Landwerlin <lionel g landwerlin linux intel com>]

On Tue, 2011-01-18 at 13:06 +0100, Juan A. Suárez Romero wrote:
> On Tue, 2011-01-18 at 12:00 +0000, Lionel Landwerlin wrote:
> 
> > > > +  insert_key_mapping (GRL_METADATA_KEY_ALBUM,
> > > > +                      MEDIA_PROP_STRING,
> > > > +                      "nmm:albumTitle(nmm:musicAlbum(?urn))",
> > > > +                      "audio");
> > > > 
> > > > 
> > > 
> > > You are hardcoding the expected type of each key, and I think that
> > > shouldn't be done.
> > > 
> > > You should use Grilo api to query what is the expected type for each
> > > key.
> > > 
> > 
> > I'm not sure to understand your point.
> > I have to associate a Tracker property to a Grilo key, where can I do
> > that outside the plugin ?
> > 
> > Regards,
> 
> 
> I didn't mean the relation between Grilo and Tracker property, but the
> expected type.
> 
> For instance, you are hardcoding that expecting type for
> GRL_KEY_METADATA_KEY_ALBUM is a string[1].
> 
> I think you should query Grilo to get what is the expected type of key,
> instead of hardcoding.
> 

That's right !
Will fix that.

Regards,

--
Lionel Landwerlin