Re: [PATCH 01/14] tracker: make query requests asynchronous



On Mon, 2011-01-17 at 10:17 +0000, llandwerlin gmail com wrote:
> +static void
> +setup_key_mappings (void)
> +{
> +  grl_to_sparql_mapping = g_hash_table_new (g_direct_hash,
> g_direct_equal);
> +  sparql_to_grl_mapping = g_hash_table_new (g_str_hash, g_str_equal);
> +
> +  insert_key_mapping (GRL_METADATA_KEY_ALBUM,
> +                      MEDIA_PROP_STRING,
> +                      "nmm:albumTitle(nmm:musicAlbum(?urn))",
> +                      "audio");
> 
> 

You are hardcoding the expected type of each key, and I think that
shouldn't be done.

You should use Grilo api to query what is the expected type for each
key.

	J.A.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]