Re: [PATCH] upnp: use given 'skip' parameter in browse/search/query

[Iago Toral <itoral igalia com>]

Pushed.

commit 441ad9d9f02253ba7760b7a448433d90adb84b10
Author: Jussi Kukkonen <jku linux intel com>
Date:   Tue Jan 18 13:01:45 2011 +0200

    upnp: use given 'skip' parameter in browse/search/query

    Signed-off-by: Iago Toral Quiroga <itoral igalia com>

---

this
BTW, while testing this I found a crasher bug in the UPnP plugin. It is 
fairly easy to reproduce for me, just go to test-ui and set these 
values:

#define BROWSE_CHUNK_SIZE   5
#define BROWSE_MAX_COUNT    20

Then execute a search on a upnp server that provides more than 5 values 
and it always crashes for me. Unfortunately, the backtrace I get is not 
meaningful to analyze the source.

Could someone else confirm the problem?

Iago

On Tue, 18 Jan 2011 13:01:45 +0200, Jussi Kukkonen 
<jku linux intel com> wrote:
> ---
>  src/upnp/grl-upnp.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/upnp/grl-upnp.c b/src/upnp/grl-upnp.c
> index c831cf8..0789fee 100644
> --- a/src/upnp/grl-upnp.c
> +++ b/src/upnp/grl-upnp.c
> @@ -1098,7 +1098,7 @@ grl_upnp_source_browse (GrlMediaSource *source,
> GrlMediaSourceBrowseSpec *bs)
>  				      "Filter", G_TYPE_STRING,
>                                        upnp_filter,
>  				      "StartingIndex", G_TYPE_UINT,
> -                                      0,
> +                                      bs->skip,
>  				      "RequestedCount", G_TYPE_UINT,
>                                        bs->count,
>  				      "SortCriteria", G_TYPE_STRING,
> @@ -1152,7 +1152,7 @@ grl_upnp_source_search (GrlMediaSource *source,
> GrlMediaSourceSearchSpec *ss)
>  				      "Filter", G_TYPE_STRING,
>                                        upnp_filter,
>  				      "StartingIndex", G_TYPE_UINT,
> -                                      0,
> +                                      ss->skip,
>  				      "RequestedCount", G_TYPE_UINT,
>                                        ss->count,
>  				      "SortCriteria", G_TYPE_STRING,
> @@ -1214,7 +1214,7 @@ grl_upnp_source_query (GrlMediaSource *source,
> GrlMediaSourceQuerySpec *qs)
>  				      "Filter", G_TYPE_STRING,
>  				      upnp_filter,
>  				      "StartingIndex", G_TYPE_UINT,
> -				      0,
> +				      qs->skip,
>  				      "RequestedCount", G_TYPE_UINT,
>  				      qs->count,
>  				      "SortCriteria", G_TYPE_STRING,