Re: UPnP plugin improvements

[Jussi Kukkonen <jku linux intel com>]

On 01/13/2011 02:17 PM, Iago Toral wrote:
> 
> On Thu, 13 Jan 2011 13:53:41 +0200, Jussi Kukkonen <jku linux intel com>
> wrote:
>> I'm sending a few fixes and improvements to grilo-upnp. They're
>> a patch set now but if one of them turns out problematic I can re-send
>> as indepependent patches.
> 
> Patches 1-3 look good to me. I'll test them and commit if no issues pop up.
> 
> The patch about the context manager needs to increase the required
> version of gupnp, we have lots of awful ifdefs in the gupnp plugin code
> to maintain compatibility with an old version of gupnp, but I think we
> should just remove all the old stuff and clean the code. We can do that
> later.

It does increase gupnp dependency to 0.13 -- we agreed with Juan that
this was the way to go. I agree that the existing gupnp-av version
checks should probably go away as well: IMO the benefit is dwarfed by
the added code complexity.

> I'll leave the review of 4th patch with the query() implementation to
> Juan and Guillaume.

Btw, Lionel just pointed out a possible memory leak in browse/search()
in IRC. I've diligently copied that into query() implementation in the
patch. I'll send a followup fix for all of them.

Jussi