Re: [PATCH 8/9] core: Use a representative element when handling multivalued data
- From: "Juan A." Suárez Romero <jasuarez igalia com>
- To: grilo-list gnome org
- Subject: Re: [PATCH 8/9] core: Use a representative element when handling multivalued data
- Date: Thu, 24 Feb 2011 10:37:12 +0100
On Thu, 2011-02-24 at 07:28 +0000, Iago Toral wrote:
> On Mon, 21 Feb 2011 10:36:34 +0100, "Juan A. Suarez Romero"
> > + if (!related_keys) {
> > + GRL_WARNING ("Not found related keys");
>
> GRL_WARNING ("Related keys not found for key: %u", related_keys->data);
> or, if we can use the registry to get the key name from the key id,
> better.
>
> > + if (!related_keys) {
> > + GRL_WARNING ("Not found related keys");
>
> Same thing here.
>
> > + if (!related_keys) {
> > + GRL_WARNING ("Not found related keys");
>
> Same here...
>
> > pos - 1);
> > if (!list_val) {
> > GRL_WARNING ("Wrong position %u when updating", pos);
>
> Let's try to be more descriptive with the warning messages:
> wrong position of what in what when dong what? :)
>
Thanks. I will.
J.A.
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]