Re: [PATCH 5/9] core: Create relation with key "url"



On Thu, 2011-02-24 at 07:21 +0000, Iago Toral wrote:
>  On Mon, 21 Feb 2011 10:36:31 +0100, "Juan A. Suarez Romero" 
>  <jasuarez igalia com> wrote:
> > Keys "url", "mime-type", "bitrate", "framerate", "height" and
> "width"
> > are correlated.
> 
>  Mmm... this is only for video, actually they would not be correlated 
>  for audio, since width and height would not make sense there for 
>  example.
>  And I wonder if that would be the case also for relations in other 
>  keys.
>  That said, I don't know if this is a real problem or not, but it is 
>  something that is not quite right and I want to confirm that is not 
>  going to be a source of trouble in the future, have you thought
> about 
>  this?
> 


The real point here is that actually, no matter if there are
correlations or not, "height" and "width" keys obviously make no sense
at all for audio content.

But in Grilo we aren't restricting which keys can be added in which type
of content, besides the restriction of using the GrlMediaAudio or
GrlMediaVideo content.

That is, if someone use GrlMediaAudio API they won't be able nor to get
nor to set width or height. Of course, casting to GrlData they would be
able to do, but this is on purpose to give more flexibility.

Told this, it means that height and width keys will be always NULL for
the case of audio, and for all cases I've been thinking about it, I
didn't see any problem.


	J.A.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]