Re: [PATCH 1/7] vimeo: Handle search all elements




On Thu, 03 Feb 2011 10:03:55 +0100, "Juan A." Suárez Romero <jasuarez igalia com> wrote:
On Thu, 2011-02-03 at 07:19 +0000, Iago Toral wrote:
 I would go more for an error message like this:
 "Unable to execute NULL-text search"
 "Unable to execute search: non NULL search text is required"

 The same for other plugins with the same issue.


Actually, besides changing the text message, I strongly think that we
should add special error for this situation,
GRL_CORE_ERROR_SEARCH_ALL_UNSUPPORTED.

Yes, I think this is a good idea. We depend on the plugin developer to use this error code appropriately in their implementations though. We should mention this in the documentation explicitly.

Iago


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]