Re: [PATCH 1/7] vimeo: Handle search all elements



On Thu, 2011-02-03 at 07:19 +0000, Iago Toral wrote:
>  I would go more for an error message like this:
>  "Unable to execute NULL-text search"
>  "Unable to execute search: non NULL search text is required"
> 
>  The same for other plugins with the same issue. 


Actually, besides changing the text message, I strongly think that we
should add special error for this situation,
GRL_CORE_ERROR_SEARCH_ALL_UNSUPPORTED.

The rationale is that programmatically I want to know in client that the
client is not supporting this operation, and thus acting accordingly.

Note than a typical error means something failed (lack of connection,
sever down, ...), so if you try later, either changing some parameter or
repeating as it is, it can succeed. But in the case of search all, no
matter what you do: source doesn't support it and full period.

IMHO it would be good that client can distinguish between both
situations.

	J.A.




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]