Re: [PATCH 2/7] core: Add API to handle "content-changed" signal

["Juan A." Suárez Romero <jasuarez igalia com>]

On Wed, 2011-02-02 at 07:27 +0000, Iago Toral wrote:
> Ok, I see you fixed this and other things I had mentioned, like the ABI 
>  issues etc in later patches in the series.
>  The commit history looks a bit weird like this IMHO. For example, first 
>  you have a commit that breaks the ABI, and later on a commit to fix that 
>  and this procedure is repeated for almost all the things I mentioned... 
>  Please , check if you can reorder/squash some of the commits. Other than 
>  this and a minor typo I sent before I think it is ready to be pushed.

Yes, and this is not so weird from git pov.

The idea is that one should keep the history to reflect how the work
evolved during the development. History should be changed only if the
real history become so messy that makes quite difficult to understand
it.

In fact, if you take a look at the commits, I did more changes than the
latest added commits, but I squashed them into previous commits because
they were providing nothing and making things more complicated.

In any case, I'll squash the last two also in previous ones.

	J.A.